Skip to content

feat(arc): give the listener container resources - #263

Merged
Mearman merged 1 commit into
mainfrom
feat/arc-listener-resources
Nov 17, 2026
Merged

Mearman merged 1 commit into
mainfrom
feat/arc-listener-resources

Conversation

@Mearman

@Mearman Mearman commented Nov 17, 2026

Copy link
Copy Markdown
Member

Adds github_runner_arc_listener_resources (default {}), rendered as resources on the overlay's listener container. The overlay's containers list replaces a values file's, so before this a listener resources block set in a profile's values file was dropped and the listener always ran BestEffort, which the kubelet evicts under memory pressure ahead of idle runner pods within their requests regardless of priority (Node-pressure eviction, "Pod selection for kubelet eviction").

Non-empty resources also open the listenerTemplate block on their own, so they reach the listener with no node label, probes or priority class set. Empty resources render the overlay byte for byte as before (checked against the main template for the default, node label, probes and priority class cases).

Documented in the role README, defaults and argument specs, with a mapping check in validate.yml.

Tests in tests/unit/test_scale_set_overlay.py cover each case that builds the listener container plus none of them, and a render through tasks/render_scale_set_values.yml over a values file with its own listener resources. They fail on main and fail again when the template's condition, the resources guard or the rendered value is broken.

Fixes #261

The chart gives each scale set's listener no resources, and the overlay's
listener container replaces any a profile's values file sets, since the
role's merge and Helm both replace lists.
A listener with no memory request is always over it,
so under node memory pressure the kubelet evicts it before idle runner
pods within their requests, whatever its PriorityClass,
and the scale set takes no job until it is rescheduled.

github_runner_arc_listener_resources (default {}) is rendered into the
overlay's listener container.
When set it also builds the listener container on its own,
without a node label, probes or a priority class;
when empty the overlay renders exactly as before.

Fixes #261
@Mearman
Mearman merged commit 1b11740 into main Nov 17, 2026
22 checks passed
@Mearman
Mearman deleted the feat/arc-listener-resources branch November 17, 2026 09:24
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let the listener container take resources

1 participant